Skip to content

Update DXIL.rst#7254

Merged
alsepkow merged 3 commits intomainfrom
alsepkow-minor-grammar-fixup
Mar 27, 2025
Merged

Update DXIL.rst#7254
alsepkow merged 3 commits intomainfrom
alsepkow-minor-grammar-fixup

Conversation

@alsepkow
Copy link
Copy Markdown
Contributor

Minor grammar fixes

Minor grammar fixes
Comment thread docs/DXIL.rst Outdated
Comment on lines +3297 to +3302
Experimental library generation is added in DXIL1.1. A library could be created by compile with lib_6_1 profile.
A library is a dxil container like the compile result of other shader profiles. The difference is library will keep information for linking like resource link info and entry function signatures.
Library support is not part of DXIL spec. Only requirement is linked shader must be valid DXIL.
Experimental library generation is added in DXIL1.1. A library could be created
by compiling with the lib_6_1 profile.
A library is a dxil container like the compile result of other shader profiles.
The difference is a library will keep information for linking like resource link
info and entry function signatures.
Library support is not part of the DXIL spec. The only requirement is linked shader must be valid DXIL.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this reflow intentional/helpful? I approve of 80-column but the rest of the doc doesn't do that (not even the first sentence of this paragraph...) and it seems odd to wrap at periods.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean wrap outside of periods? I don't mind sentences having their own lines to limit the sidescroll where relevant, but I think that since this is mostly consumed in plain text, it's better to not break up sentences.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bah, that's from my editor config. I have it set to show me everything as 80 columns now, but I also hit the hotkey to format this after I edited it. Will restore the original formatting.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold on, I take that back. I edited this through the browser. I don't know how I goofed up that formatting. Will fix either way.

@alsepkow alsepkow merged commit 0fa207a into main Mar 27, 2025
13 checks passed
@alsepkow alsepkow deleted the alsepkow-minor-grammar-fixup branch March 27, 2025 18:09
@github-project-automation github-project-automation Bot moved this from New to Done in HLSL Roadmap Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants